[theora-dev] Multi-Thread Theora Encoder

[Maik Merten]

Felipe Portavales Goldstein schrieb:
>> encode.c, PickModes() (starting with line 1439) has a few mallocs for
>> your multithreading data structures. If the return statement in line
>> 1467 gets triggered the memory allocated doesn't reveive the free()
>> calls it deserves. (if I don't miss something, one can rightfully call
>> me a C newbie).
> 
> Yes,
> Thanks for noting that. This is a really serious bug.

Just wanted to point out that I replaced that premature return statement
causing the memory leak with something better in this commit:
http://lists.xiph.org/pipermail/commits/2007-October/012375.html

If you replicate that in your version the memory leak will be gone.


Maik