[Theora-dev] Re: Invalid read of size 1...

[Ralph Giles]

On Fri, Oct 28, 2005 at 02:40:30PM +0200, Mat wrote:

> The small leak in my app is gone.

Glad we found it.

> ==2782== Invalid read of size 1
> ==2782==    at 0x1B94B0BD: PixelLineSearch (scan.c:1482)

Yes, the scan stuff will definitely be input dependent. Good spotting, 
this is a real bug (inherited from the VP3 codebase, looks like). There 
are similar issues with some of the other search directions.

Has anyone else read this code? I'm a little unclear on why the bounds 
check it does do can just wrap the buffer. Obviously the bounds check 
needs to be fixed/augmented, but I'm not sure what it should in those 
cases.

 -r