[Theora-dev] [patch] fixes for avi2vp3

Nehal nehalmistry at gmx.net
Sat Feb 26 19:45:35 PST 2005


here is a patch that fixes various bugs/problems with avi2vp3:

1. open() is not called with O_BINARY , this causes the program to
crash or give undesired results on win32 (and maybe other
platforms?), as binary mode is not default.

2. win32 does not understand chmod flags, ie:
(S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH)

3. buffer = malloc(AVI_max_video_chunk(avifile));
for some reason, AVI_max_video_chunk(avifile) returns 0, i've
set an arbitrary high value for it until someone fixes it
correctly.

-- Nehal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: avi2vp3-fixes-nehal.diff
Type: application/octet-stream
Size: 1856 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/theora-dev/attachments/20050226/2e1f7cef/avi2vp3-fixes-nehal.obj


More information about the Theora-dev mailing list