[theora-dev] My issues with ogg and directshow...

[Michael Smith]

On Tuesday 11 May 2004 13:10, illiminable wrote:
> This is from libfishsound, which is the wrapper i'm using to libvorbis...
>
> /* Make a fake ogg_packet structure to pass the data to libvorbis */
>   op.packet = buf;
>   op.bytes = bytes;
>   op.b_o_s = (fsv->packetno == 0) ? 1 : 0;
>   op.e_o_s = 0;
>   op.granulepos = 7;
>   op.packetno = fsv->packetno;
>
> I've been using it just fine, and i'm sure conrad has been for a lot
> longer, i'm sure he can explain why it works !... it clearly doesn't make
> that much difference... if any at all.
>
> A quick search in libvorbis, i can see it being stored a few places... but
> not actually used for anything !

It's used (and is crucial for) proper handling of short packets ('short' in 
the sense used in the recent mux meeting).

If libfishsound is doing this, it's going to get decode wrong at start and end 
of stream. It's even-more-obviously going to get it wrong at end of stream 
since op.e_o_s never gets set in the code you gave above. 

Mike

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'theora-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.