[Theora-dev] theora_decode_init bug

Ralph Giles giles
Wed Aug 4 19:40:50 PDT 2004

On Thu, Aug 05, 2004 at 01:13:59AM +0200, Erik Olofsson wrote:
> I found a bug in theora_decode_init when I was implementing the decoder.
> theora_decode_init should be zeroing the theora state structure right?

How so? Everything should be initialized properly. The only advantage of
nulling the structure ahead of time is if it's more likely to allow the
program to continue after an error. I don't believe this is such a case.

>   memset(th, 0, sizeof(theora_state));

Can you point to something specific that goes wrong without this line?


More information about the Theora-dev mailing list