[speex-dev] Thread Safety

Jean-Marc Valin Jean-Marc.Valin at USherbrooke.ca
Wed Oct 29 21:41:16 PST 2003


Le mer 29/10/2003 à 23:56, Aron Rosenberg a écrit :
> Can you post a quick patch to the list or point out what the problem was.

The problem is in quant_lsp.c at the top, with the following
declaration:
static float quant_weight[MAX_LSP_SIZE];

The fix is very easy and consists of simply making the declaration
non-static and to include it in each of the lsp_quant_* functions as a
normal local variable.

        Jean-Marc

> At 08:36 PM 10/29/2003, you wrote:
> > > Yes, i have been using speex in my VoIP gateway product. There are
> > > hundreds of threads that simultaneously call various speex APIs and
> > > execute without any problem. But ofcourse, I use a speex encoder/decoder
> > > vars on per stream basis. Its been tested successfully on Linux/Win2k.
> >
> >Actually, I just realized I fixed a potential minor thread problem
> >recently. It's in 1.1.1 but not in 1.0.2. I say the problem is minor
> >because the worst case is slightly suboptimal encoding (decoding not
> >affected), but no crash or pathological results. I'll include the fix in
> >the next stable release.
> >
> >         Jean-Marc
> >
> >--
> >Jean-Marc Valin, M.Sc.A., ing. jr.
> >LABORIUS (http://www.gel.usherb.ca/laborius)
> >Université de Sherbrooke, Québec, Canada
> 
> 
> --- >8 ----
> List archives:  http://www.xiph.org/archives/
> Ogg project homepage: http://www.xiph.org/ogg/
> To unsubscribe from this list, send a message to 'speex-dev-request at xiph.org'
> containing only the word 'unsubscribe' in the body.  No subject is needed.
> Unsubscribe messages sent to the list will be ignored/filtered.

-- 
Jean-Marc Valin, M.Sc.A., ing. jr.
LABORIUS (http://www.gel.usherb.ca/laborius)
Université de Sherbrooke, Québec, Canada


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: Ceci est une partie de message numériquement signée
Url : http://lists.xiph.org/pipermail/speex-dev/attachments/20031030/27697904/signature-0001.pgp


More information about the Speex-dev mailing list