[Paranoia-dev] Fwd: [PATCH] Fix reading last track when using -O on some drives

Weird Kerning weirdkerning at gmail.com
Tue Jul 30 08:02:54 PDT 2013


Hi,

Sorry, just realized I sent these to the wrong list. Didn't realize there
was a -dev mailing list.

The second patch fixes an issue that occurs for some (but not all,
apparently) drives that do not support overreading when ripping the last
audio track if it's followed by a data track.


---------- Forwarded message ----------
From: Weird Kerning <weirdkerning at gmail.com>
Date: Mon, Jul 29, 2013 at 11:15 AM
Subject: [PATCH] Fix reading last track when using -O on some drives
To: paranoia at xiph.org


Hi,

It's often desirable to pass -O <sample offset> when ripping discs so that
it's easy to assess the accuracy of the rip by comparing to the rips other
have made by using AccurateRip and the like. On drives that require a large
-- presumably >= 588 -- sample offset correction that do not support
reading into the lead-out area of the disc, cdparanoia will cause (Linux --
not tested elsewhere) kernel transport errors and will fail when trying to
rip the last track.

This patch adds an option to force overreading into the lead-out (-x,
--force-overread) when ripping the last track on the disc, which is
disabled by default, since most drives are not actually able to
successfully do this. When it's not enabled, digital silence is written to
pad out the extracted audio so the track is the correct length. This
matches the behavior of other popular DAE tools like EAC and dbpoweramp.

This patch also fixes a bug that prevented overreading into the lead-out
from working even on drives that do support it. Without this patch when
using a read offset correction even for drives that do correctly overread,
the samples that are in the lead-out after offset correction were not being
correctly read, and were being written to the output as digital silence.
This patch forces a buffer flush before trying to read the extra sectors,
which causes the data to actually be read.

This patch resolves issues users have hit this issue:
https://github.com/thomasvs/morituri/issues/36  when using morituri, a cli
DAE tool that uses cdparanoia for audio extraction.

Patch is against the head of the cdparanoia svn repo. Please apply if
appropriate.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.xiph.org/pipermail/paranoia-dev/attachments/20130730/e4d81f91/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01-overread.patch
Type: application/octet-stream
Size: 7497 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/paranoia-dev/attachments/20130730/e4d81f91/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02-overread_data.patch
Type: application/octet-stream
Size: 1961 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/paranoia-dev/attachments/20130730/e4d81f91/attachment-0001.obj 


More information about the Paranoia-dev mailing list