<div dir="ltr"><div><div>Hi,<br><br></div>Sorry, just realized I sent these to the wrong list. Didn't realize there was a -dev mailing list.<br><br></div>The second patch fixes an issue that occurs for some (but not all, apparently) drives that do not support overreading when ripping the last audio track if it's followed by a data track.<br>
<div><br><br><div><div>---------- Forwarded message ----------<br><div class="gmail_quote">From: <b class="gmail_sendername">Weird Kerning</b> <span dir="ltr"><<a href="mailto:weirdkerning@gmail.com">weirdkerning@gmail.com</a>></span><br>
Date: Mon, Jul 29, 2013 at 11:15 AM<br>Subject: [PATCH] Fix reading last track when using -O on some drives<br>To: <a href="mailto:paranoia@xiph.org">paranoia@xiph.org</a><br><br><br><div dir="ltr"><div><div><div><div>Hi,<br>
<br></div>It's often desirable to pass -O <sample offset> when ripping discs so that it's easy to assess the accuracy of the rip by comparing to the rips other have made by using AccurateRip and the like. On drives that require a large -- presumably >= 588 -- sample offset correction that do not support reading into the lead-out area of the disc, cdparanoia will cause (Linux -- not tested elsewhere) kernel transport errors and will fail when trying to rip the last track.<br>
<br></div>This patch adds an option to force overreading into the lead-out (-x, --force-overread) when ripping the last track on the disc, which is disabled by default, since most drives are not actually able to successfully do this. When it's not enabled, digital silence is written to pad out the extracted audio so the track is the correct length. This matches the behavior of other popular DAE tools like EAC and dbpoweramp.<br>
<br></div>This patch also fixes a bug that prevented overreading into the lead-out from working even on drives that do support it. Without this patch when using a read offset correction even for drives that do correctly overread, the samples that are in the lead-out after offset correction were not being correctly read, and were being written to the output as digital silence. This patch forces a buffer flush before trying to read the extra sectors, which causes the data to actually be read.<br>
<br></div><div>This patch resolves issues users have hit this issue: <a href="https://github.com/thomasvs/morituri/issues/36" target="_blank">https://github.com/thomasvs/morituri/issues/36</a> when using morituri, a cli DAE tool that uses cdparanoia for audio extraction.<br>
</div><div><br></div><div>Patch is against the head of the cdparanoia svn repo. Please apply if appropriate.<br></div></div>
</div><br></div></div></div></div>