[paranoia-dev] Include file dependencies

[Peter Jones]

Hey guys,

I recently got a bug report from a user of jhbuild, a utility for building
gnome from CVS, who says that our current header files cause gnome-vfs 
not to build.  His complaint is that cdda_paranoia.h always requires
cdda_interface.h to be included because of typedef cdrom_drive , and for
some reason not including it confuses jhbuild.

I've never used the utility, but to me it seems like he's right, and
there's no reason not to simply include cdda_interface.h from
cdda_paranoia.h .  If nobody complains, I'd like to apply this to CVS
pretty soon:

diff -u -r1.9 cdda_paranoia.h
--- paranoia/cdda_paranoia.h    24 Mar 2001 01:15:47 -0000      1.9
+++ paranoia/cdda_paranoia.h    2 Sep 2003 15:37:35 -0000
@@ -7,6 +7,8 @@
 #ifndef _CDROM_PARANOIA_
 #define _CDROM_PARANOIA_
  
+#include <cdda/cdda_interface.h>
+
 #define CD_FRAMEWORDS (CD_FRAMESIZE_RAW/2)
  
 #define PARANOIA_CB_READ           0

If I don't hear any complaints, I'll probably commit it later this week ;)


-- 
        Peter

All parts should go together without forcing. You must remember that
the parts you are  reassembling were disassembled by you.  Therefore,
if you can't get them together again, there must be a reason. By all
means, do not use a hammer.
		-- IBM maintenance manual, 1925

--- >8 ----
List archives:  http://www.xiph.org/archives/
Paranoia homepage: http://www.xiph.org/paranoia/
To unsubscribe from this list, send mail to 'paranoia-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.