[opus] Misc patches

Jean-Marc Valin jmvalin at jmvalin.ca
Thu Jun 11 17:49:27 UTC 2020


On 2020-06-08 01:39, Marcus Asteborg wrote:
>  1. Build test for cmake and run the test in gitlab-ci.

OK, merged.

>  2. Disable the message box on Windows on abort that cause test hangs in CI.

Merged too.

>  3. Build time improvement by removing unnecessary includes of stdio.h
>     in production code and change to a lighter header intrin.h ->
>     intrin0.h (windows only). Attached screenshot of measurement but it
>     resulted in 14% buildspeed compared to master on Windows 64 debug
>     builds on my setup. As most improvements comes from change intrin.h
>     the impact on other platforms will not be that much.

I'm having a bit of an issue with the change to debug.h. I'm not sure 
exactly what you're trying to do, but the

#ifdef HAVE_CONFIG_H
#include "config.h"
#endif

should always be there (unconditionally) at the top of C files. Any 
reason you want to move an include before it and make it conditional?

Cheers,

	Jean-Marc


More information about the opus mailing list