[opus] Int overflow fix not present in tree.

Yves Gerey yvesg at google.com
Thu Sep 12 16:58:22 UTC 2019

Thanks for the details!

On Tue, Sep 10, 2019 at 8:43 PM Timothy B. Terriberry <tterribe at xiph.org>

> Felicia Lim wrote:
> > Hi Yves,
> >
> > At that time, the issue wasn't reproducible in opus master, but there
> > had been some significant changes since the last tagged release that
> > made it hard to pinpoint a single patch to cherry pick to Chromium,
> > hence this local fix.
> I'm not convinced that using a saturating add here is the correct thing
> to do, either (as opposed to, say, multiplying out by the coefficients
> individually).
> Either way, there are exact analogs of this code in NSQ.c, as well as
> all of the SIMD optimizations (x86/NSQ_sse4_1.c and
> x86/NSQ_del_dec_sse4_1.c, arm/NSQ_del_dec_neon_intr.c, and
> mips/NSQ_del_dec_mipsr1.h). If it is a possible issue in master, the fix
> looks incomplete to me, at least.

Warm regards,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xiph.org/pipermail/opus/attachments/20190912/14b309b5/attachment.html>

More information about the opus mailing list