[opus] [PATCH] Add missing HAVE_CONFIG_H guards

Jean-Marc Valin jmvalin at jmvalin.ca
Wed Feb 15 18:45:10 UTC 2017


Hi Michael,

I guess the main issue here is that config.h is never actually supposed
to be included from a header file in the first place. So it might be
best to fix that directly rather than adding ifdefs.

Cheers,

	Jean-Marc

On 15/02/17 01:21 PM, Michael Bradshaw wrote:
> On Fri, Jan 27, 2017 at 7:39 PM, Michael Bradshaw <mjbshaw at google.com
> <mailto:mjbshaw at google.com>> wrote:
> 
>     Attached patch adds some missing HAVE_CONFIG_H guards to some places
>     in celt/arm. Please review.
> 
> 
> Hi again. Just following up to see if there are any additional changes
> that I should make to this patch. Without it, using Ne10 fails to build
> without a config.h file present.
> 
> --Michael
> 
> 
> _______________________________________________
> opus mailing list
> opus at xiph.org
> http://lists.xiph.org/mailman/listinfo/opus
> 


More information about the opus mailing list