[opus] [PATCH] fix alignment exceptions

[Jonathan Lennox]

This would revert a patch I submitted two years ago (http://git.xiph.org/?p=opus.git;a=commitdiff;h=1d60b49e9d95672a17ebe5578319c59fa3963224).

At the time, clang produced an unnecessary MOVQ instruction when it compiled with the version of the code with the explicit _mm_loadl_epi64 intrinsic.  Do you no longer see that?

How does the code compile for you, and what is the issue you’re seeing?  (One issue might be that clang’s address sanitizer isn’t smart enough to know that PMOVSXWD only loads 8 bytes, despite _mm_cvtepi16_epi32’s argument being an __mm128i; I’ve seen it trigger incorrect out-of-bounds read errors.)

On Aug 18, 2017, at 12:34 PM, Felicia Lim <flim at google.com<mailto:flim at google.com>> wrote:

Hi,

Please find attached a patch to fix alignment exceptions. Without this change, we were seeing occasional alignment faults when using this with clang.

Thanks,
Felicia
<e5c277c.diff>_______________________________________________
opus mailing list
opus at xiph.org<mailto:opus at xiph.org>
http://lists.xiph.org/mailman/listinfo/opus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xiph.org/pipermail/opus/attachments/20170818/fa80aab9/attachment.html>