<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
<div class="">This would revert a patch I submitted two years ago (<a href="http://git.xiph.org/?p=opus.git;a=commitdiff;h=1d60b49e9d95672a17ebe5578319c59fa3963224" class="">http://git.xiph.org/?p=opus.git;a=commitdiff;h=1d60b49e9d95672a17ebe5578319c59fa3963224</a>).</div>
<div class=""><br class="">
</div>
<div class="">At the time, clang produced an unnecessary MOVQ instruction when it compiled with the version of the code with the explicit _mm_loadl_epi64 intrinsic. Do you no longer see that?</div>
<div class=""><br class="">
</div>
<div class="">How does the code compile for you, and what is the issue you’re seeing? (One issue might be that clang’s address sanitizer isn’t smart enough to know that PMOVSXWD only loads 8 bytes, despite _mm_cvtepi16_epi32’s argument being an __mm128i; I’ve
seen it trigger incorrect out-of-bounds read errors.) </div>
<div class=""><br class="">
</div>
<div>
<blockquote type="cite" class="">
<div class="">On Aug 18, 2017, at 12:34 PM, Felicia Lim <<a href="mailto:flim@google.com" class="">flim@google.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" class="">
<div class=""><span style="font-size:13px;color:rgb(33,33,33)" class="">Hi,</span></div>
<div class=""><span style="font-size:13px;color:rgb(33,33,33)" class=""><br class="">
</span></div>
<div class=""><span style="font-size:13px;color:rgb(33,33,33)" class="">Please find attached a patch to fix alignment exceptions. </span><span style="font-size:13px;color:rgb(33,33,33)" class="">Without this change, we were seeing occasional alignment faults
when using this with clang.</span></div>
<div class=""><span style="font-size:13px;color:rgb(33,33,33)" class=""><br class="">
</span></div>
<div class=""><span style="font-size:13px;color:rgb(33,33,33)" class="">Thanks,</span></div>
<div class=""><span style="font-size:13px;color:rgb(33,33,33)" class="">Felicia</span></div>
</div>
<span id="cid:15df62dbda7a4b2172f1"><e5c277c.diff></span>_______________________________________________<br class="">
opus mailing list<br class="">
<a href="mailto:opus@xiph.org" class="">opus@xiph.org</a><br class="">
http://lists.xiph.org/mailman/listinfo/opus<br class="">
</div>
</blockquote>
</div>
<br class="">
</body>
</html>