[opus] [PATCH] Add Functions to Create Ambisonic Multistream Encoder

[Michael Graczyk]

On May 20, 2016 18:32, "Jean-Marc Valin" <jmvalin at jmvalin.ca> wrote:
>
> Is it intended that this patch never sets ALLOCATION_MODE_AMBISONICS?
> I'm having a hard time figuring out what it does in its current state.
That was intended. I wanted to "reserve" the number 2 in this enum to make
it clear that 2 would mean ambisonics in the future.

> Also, I think the ambisonics function should be completely disabled
> (hidden behind EXPERIMENTAL_AMBISONICS/--enable-experimental-ambisonics
> flags) until there's actually an approved spec to avoid problems in the
> future.
I believe I did that already. It should be the case that without that flag,
this patch is a noop. Did I miss something?

>As for the mapping family to use, I'm not yet sure whether it's
> best to use 2 or 255 for now -- Tim, any opinion?
Isn't 255 best reserved to mean "no mapping" as it does now?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.xiph.org/pipermail/opus/attachments/20160520/571e72e2/attachment.html>