[opus] [PATCH] Add Functions to Create Ambisonic Multistream Encoder

[Jean-Marc Valin]

On 05/16/2016 05:06 AM, Michael Graczyk wrote:
> Does anyone have more thoughts on this patch? I would like to get this
> in so I can send more involved patches related to ambisonics.

Is it intended that this patch never sets ALLOCATION_MODE_AMBISONICS?
I'm having a hard time figuring out what it does in its current state.
Also, I think the ambisonics function should be completely disabled
(hidden behind EXPERIMENTAL_AMBISONICS/--enable-experimental-ambisonics
flags) until there's actually an approved spec to avoid problems in the
future. As for the mapping family to use, I'm not yet sure whether it's
best to use 2 or 255 for now -- Tim, any opinion?

> Also, do you guys prefer to do code review using pull requests on
> github? It seems that both are used for Opus. 

I actually prefer patches by email on this list.

Cheers,

	Jean-Marc

> On Fri, May 6, 2016 at 4:46 PM, Michael Graczyk <mgraczyk at google.com
> <mailto:mgraczyk at google.com>> wrote:
> 
>     Here is the modified patch. I added a flag to configure.ac
>     <http://configure.ac> which is set to 0 to disable ambisonics, and 1
>     to enable it. Right now the implementation simply creates a surround
>     encoder with N uncoupled streams.
> 
> 
>     Thanks,
>     Michael Graczyk
> 
> 
> 
> 
> -- 
> 
> Thanks,
> Michael Graczyk