[opus] [PATCH] win32: only use dllexport when building DLL

Ralph Giles giles at thaumas.net
Wed Apr 20 17:38:05 UTC 2016

Pushed. Thanks for the patch!


On 09/04/16 03:01 PM, Daniel Verkamp wrote:
> On Wed, Oct 21, 2015 at 6:38 PM, Daniel Verkamp <daniel at drv.nu> wrote:
>> If building a static library, marking symbols as dllexport causes them
>> to be exported from the final executable. For example, run
>> objdump -x opus_demo.exe on a --disabled-shared build and look for the
>> export table; there should not be one in a normal Win32 .exe file, but
>> when linking static libopus, the exe exports all of the opus_* public
>> functions.
>> Use the libtool-defined DLL_EXPORT flag to determine whether we are
>> building a DLL and only specify __declspec(dllexport) in that case.
> Any updates on this patch (attached again just to be sure)?
> It still applies to the current master branch.
> Thanks,
> -- Daniel
> _______________________________________________
> opus mailing list
> opus at xiph.org
> http://lists.xiph.org/mailman/listinfo/opus

More information about the opus mailing list