[opus] [PATCH] win32: only use dllexport when building DLL

LRN lrn1986 at gmail.com
Thu Oct 22 03:02:41 PDT 2015


On 22.10.2015 4:38, Daniel Verkamp wrote:
> If building a static library, marking symbols as dllexport causes them
> to be exported from the final executable. For example, run
> objdump -x opus_demo.exe on a --disabled-shared build and look for the
> export table; there should not be one in a normal Win32 .exe file, but
> when linking static libopus, the exe exports all of the opus_* public
> functions.
> 
> Use the libtool-defined DLL_EXPORT flag to determine whether we are
> building a DLL and only specify __declspec(dllexport) in that case.

Works for me (as in "doesn't break anything"; i don't do static builds).

-- 
O< ascii ribbon - stop html email! - www.asciiribbon.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0x922360B0.asc
Type: application/pgp-keys
Size: 1702 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/opus/attachments/20151022/1a2d90ac/attachment.key 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
Url : http://lists.xiph.org/pipermail/opus/attachments/20151022/1a2d90ac/attachment.pgp 


More information about the opus mailing list