[opus] [PATCH] Remove dead code

Jean-Marc Valin jmvalin at jmvalin.ca
Wed Oct 23 13:33:10 PDT 2013


Hi Stefan,

Sorry your message got stuck in the moderation queue, but it's committed
now.

Cheers,

	Jean-Marc

On 10/08/2013 06:01 PM, Stefan Beller wrote:
> The compiler warned:
> silk/float/pitch_analysis_core_FLP.c: In function 'silk_P_Ana_calc_corr_st3':
> silk/float/pitch_analysis_core_FLP.c:499:36: warning: variable 'basis_ptr' set but not used [-Wunused-but-set-variable]
>      const silk_float *target_ptr, *basis_ptr;
> 
> This means we can safely remove it.
> 
> Signed-off-by: Stefan Beller <stefanbeller at googlemail.com>
> ---
>  silk/float/pitch_analysis_core_FLP.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/silk/float/pitch_analysis_core_FLP.c b/silk/float/pitch_analysis_core_FLP.c
> index 605ea25..b6bafe8 100644
> --- a/silk/float/pitch_analysis_core_FLP.c
> +++ b/silk/float/pitch_analysis_core_FLP.c
> @@ -496,7 +496,7 @@ static void silk_P_Ana_calc_corr_st3(
>      opus_int            complexity          /* I Complexity setting                                             */
>  )
>  {
> -    const silk_float *target_ptr, *basis_ptr;
> +    const silk_float *target_ptr;
>      opus_int   i, j, k, lag_counter, lag_low, lag_high;
>      opus_int   nb_cbk_search, delta, idx, cbk_size;
>      silk_float scratch_mem[ SCRATCH_SIZE ];
> @@ -529,7 +529,6 @@ static void silk_P_Ana_calc_corr_st3(
>          silk_assert(lag_high-lag_low+1 <= SCRATCH_SIZE);
>          celt_pitch_xcorr( target_ptr, target_ptr - start_lag - lag_high, xcorr, sf_length, lag_high - lag_low + 1 );
>          for( j = lag_low; j <= lag_high; j++ ) {
> -            basis_ptr = target_ptr - ( start_lag + j );
>              silk_assert( lag_counter < SCRATCH_SIZE );
>              scratch_mem[ lag_counter ] = xcorr[ lag_high - j ];
>              lag_counter++;
> 



More information about the opus mailing list