[opus] [PATCH] opusfile configury fixes.

[Diego Elio Pettenò]

My personal suggestion is not to try to be compatible with libtool-1.4
(which is what this patch is about) because not only it's ancient but it's
seriously bugged in way too many configurations.


Diego Elio Pettenò — Flameeyes
flameeyes at flameeyes.eu — http://blog.flameeyes.eu/


On Thu, May 9, 2013 at 6:52 AM, Ozkan Sezer <sezeroz at gmail.com> wrote:

> On Wed, May 8, 2013 at 10:54 PM, Ozkan Sezer <sezeroz at gmail.com> wrote:
> > On Wed, May 8, 2013 at 10:34 PM, Ralph Giles <giles at thaumas.net> wrote:
> >> On 13-05-08 11:46 AM, Ozkan Sezer wrote:
> >
> >>> The autogen.sh of opusfile doesn't work for me:
> >>>
> >>> Makefile.am:10: Libtool library used but `LIBTOOL' is undefined
> >>> Makefile.am:10:   The usual way to define `LIBTOOL' is to add
> `AC_PROG_LIBTOOL'
> >>
> >> Your autotools is too old for LT_INIT maybe?
> >>
> >
> > Edited autogen.sh to change autoreconf to autoreconf-2.68 and ran:
> >
> > $ AUTOCONF=autoconf-2.68 AUTOHEADER=autoheader-2.68
> > AUTOM4TE=autom4te-2.68 ACLOCAL=aclocal-1.11.6 AUTOMAKE=automake-1.11.6
> > ./autogen.sh
> > Updating build configuration files for opusfile, please wait....
> > configure.ac:8: installing `./install-sh'
> > configure.ac:8: installing `./missing'
> > Makefile.am:10: Libtool library used but `LIBTOOL' is undefined
> > Makefile.am:10:   The usual way to define `LIBTOOL' is to add `LT_INIT'
> > Makefile.am:10:   to `configure.ac' and run `aclocal' and `autoconf'
> again.
> > Makefile.am:10:   If `LT_INIT' is in `configure.ac', make sure
> > Makefile.am:10:   its definition is in aclocal's search path.
> > Makefile.am: installing `./depcomp'
> > autoreconf-2.68: automake-1.11.6 failed with exit status: 1
> >
> > I think autoconf-2.68 and automake-1.11.6 are good enough?
> >
>
> Tried the existing configury on a newer distro (fedora 16) installation,
> and it worked without issues.  So, the problem seems to be with my old
> setup (fedora 9) with old default autotools and libtool versions.
>
> >>> The
> >>> last hunk touching the AC_CHECK_HEADER use is needed for me, otherwise
> >>> the generated configure is broken (using autoconf-2.63, newer versions
> >>> are _possibly_ OK with the existing syntax).
> >>
> >> I'm surprised by this. autoconf has has optional arguments since before
> >> 2.63. Can you be specific about what's broken?
> >
> > If I don't edit the AC_CHECK_HEADER stuff, the following happens:
> >
> > $ ./configure --disable-http
> > [...]
> > checking if gcc supports -Wno-parentheses flag... yes
> > checking if gcc supports -Wno-long-long flag... yes
> > ./configure: line 21062: syntax error near unexpected token `newline'
> > ./configure: line 21062: `  yes:no:'
> >
> > The lines around 21062 look like:
> > [...]
> > # So?  What about this header?
> > case $ac_header_compiler:$ac_header_preproc:$ac_c_preproc_warn_flag in
> >   yes:no:
> > fi
> >
> >     { $as_echo "$as_me:$LINENO: WARNING: winsock2.h: accepted by the
> compiler
> > else
> >   rejected by the preprocessor!" >&5
> >
> >>
> >>  -r
> >
> > --
> > O.S.
>
> In short, the existing version is fine with new autotools+libtool, yes,
> but the patch I suggested makes it to work on older setups too and w/o
> any added bugs. So I'd suggest that you consider it.
>
> --
> O.S.
> _______________________________________________
> opus mailing list
> opus at xiph.org
> http://lists.xiph.org/mailman/listinfo/opus
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.xiph.org/pipermail/opus/attachments/20130509/18951abe/attachment.htm