<div dir="ltr">My personal suggestion is not to try to be compatible with libtool-1.4 (which is what this patch is about) because not only it's ancient but it's seriously bugged in way too many configurations.<div>
<br></div></div><div class="gmail_extra"><br clear="all"><div>Diego Elio Pettenò — Flameeyes<br><a href="mailto:flameeyes@flameeyes.eu" target="_blank">flameeyes@flameeyes.eu</a> — <a href="http://blog.flameeyes.eu/" target="_blank">http://blog.flameeyes.eu/</a></div>
<br><br><div class="gmail_quote">On Thu, May 9, 2013 at 6:52 AM, Ozkan Sezer <span dir="ltr"><<a href="mailto:sezeroz@gmail.com" target="_blank">sezeroz@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Wed, May 8, 2013 at 10:54 PM, Ozkan Sezer <<a href="mailto:sezeroz@gmail.com">sezeroz@gmail.com</a>> wrote:<br>
> On Wed, May 8, 2013 at 10:34 PM, Ralph Giles <<a href="mailto:giles@thaumas.net">giles@thaumas.net</a>> wrote:<br>
>> On 13-05-08 11:46 AM, Ozkan Sezer wrote:<br>
><br>
>>> The autogen.sh of opusfile doesn't work for me:<br>
>>><br>
>>> Makefile.am:10: Libtool library used but `LIBTOOL' is undefined<br>
>>> Makefile.am:10: The usual way to define `LIBTOOL' is to add `AC_PROG_LIBTOOL'<br>
>><br>
>> Your autotools is too old for LT_INIT maybe?<br>
>><br>
><br>
> Edited autogen.sh to change autoreconf to autoreconf-2.68 and ran:<br>
><br>
> $ AUTOCONF=autoconf-2.68 AUTOHEADER=autoheader-2.68<br>
> AUTOM4TE=autom4te-2.68 ACLOCAL=aclocal-1.11.6 AUTOMAKE=automake-1.11.6<br>
> ./autogen.sh<br>
> Updating build configuration files for opusfile, please wait....<br>
> <a href="http://configure.ac:8" target="_blank">configure.ac:8</a>: installing `./install-sh'<br>
> <a href="http://configure.ac:8" target="_blank">configure.ac:8</a>: installing `./missing'<br>
> Makefile.am:10: Libtool library used but `LIBTOOL' is undefined<br>
> Makefile.am:10: The usual way to define `LIBTOOL' is to add `LT_INIT'<br>
> Makefile.am:10: to `<a href="http://configure.ac" target="_blank">configure.ac</a>' and run `aclocal' and `autoconf' again.<br>
> Makefile.am:10: If `LT_INIT' is in `<a href="http://configure.ac" target="_blank">configure.ac</a>', make sure<br>
> Makefile.am:10: its definition is in aclocal's search path.<br>
> Makefile.am: installing `./depcomp'<br>
> autoreconf-2.68: automake-1.11.6 failed with exit status: 1<br>
><br>
> I think autoconf-2.68 and automake-1.11.6 are good enough?<br>
><br>
<br>
</div>Tried the existing configury on a newer distro (fedora 16) installation,<br>
and it worked without issues. So, the problem seems to be with my old<br>
setup (fedora 9) with old default autotools and libtool versions.<br>
<div><div class="h5"><br>
>>> The<br>
>>> last hunk touching the AC_CHECK_HEADER use is needed for me, otherwise<br>
>>> the generated configure is broken (using autoconf-2.63, newer versions<br>
>>> are _possibly_ OK with the existing syntax).<br>
>><br>
>> I'm surprised by this. autoconf has has optional arguments since before<br>
>> 2.63. Can you be specific about what's broken?<br>
><br>
> If I don't edit the AC_CHECK_HEADER stuff, the following happens:<br>
><br>
> $ ./configure --disable-http<br>
> [...]<br>
> checking if gcc supports -Wno-parentheses flag... yes<br>
> checking if gcc supports -Wno-long-long flag... yes<br>
> ./configure: line 21062: syntax error near unexpected token `newline'<br>
> ./configure: line 21062: ` yes:no:'<br>
><br>
> The lines around 21062 look like:<br>
> [...]<br>
> # So? What about this header?<br>
> case $ac_header_compiler:$ac_header_preproc:$ac_c_preproc_warn_flag in<br>
> yes:no:<br>
> fi<br>
><br>
> { $as_echo "$as_me:$LINENO: WARNING: winsock2.h: accepted by the compiler<br>
> else<br>
> rejected by the preprocessor!" >&5<br>
><br>
>><br>
>> -r<br>
><br>
> --<br>
> O.S.<br>
<br>
</div></div>In short, the existing version is fine with new autotools+libtool, yes,<br>
but the patch I suggested makes it to work on older setups too and w/o<br>
any added bugs. So I'd suggest that you consider it.<br>
<div class="HOEnZb"><div class="h5"><br>
--<br>
O.S.<br>
_______________________________________________<br>
opus mailing list<br>
<a href="mailto:opus@xiph.org">opus@xiph.org</a><br>
<a href="http://lists.xiph.org/mailman/listinfo/opus" target="_blank">http://lists.xiph.org/mailman/listinfo/opus</a><br>
</div></div></blockquote></div><br></div>