[CELT-dev] Possible bug in CELT's VBR code

[Jean-Marc Valin]

Hi,

Sorry I didn't look properly (or at the right place). I think you're  
right that it needs to be "vbr_rate>>(3+BITRES)". Thanks for spotting  
this.

Cheers,

    Jean-Marc

John Ridges <jridges at masque.com> a écrit :

> Hi Jean-Marc,
>
> This file (celt.c) is the one I got out of the celt-0.11.1.tar.gz  
> tarbal. Is is possible that the 0.11.1 release doesn't have the  
> latest code?
>
> John Ridges
>
> On 2/28/2011 6:48 PM, Jean-Marc Valin wrote:
>> Hi,
>>
>> I'm not sure what version you're using (this code no longer  
>> exists), but you should be aware that VBR was pretty broken until  
>> version 0.10. If you're using something earlier than 0.10, I  
>> recommend either upgrading or using CBR.
>>
>> Cheers,
>>
>>    Jean-Marc
>>
>> On 11-02-28 07:55 PM, John Ridges wrote:
>>> Hi guys,
>>>
>>> It looks to me like line 955 in celt.c should be:
>>>
>>>        effectiveBytes = vbr_rate>>(3+BITRES);
>>>
>>> otherwise it seems like "effectiveBytes" is 8 times larger than it
>>> should be (at least if it's really meant to be bytes).
>>>
>>> Cheers,
>>> John Ridges
>>>
>>>
>>> _______________________________________________
>>> celt-dev mailing list
>>> celt-dev at xiph.org
>>> http://lists.xiph.org/mailman/listinfo/celt-dev
>>>
>>>
>>
>>
>
>
>