[ogg-dev] Fixing ogg vorbis corruption caused by bad metadata

Adam Rosi-Kessel adam at rosi-kessel.org
Thu Jul 23 10:08:32 PDT 2009


On Jul 23, 2009, at 12:44 PM, Monty Montgomery <monty at xiph.org> wrote:

>> However, there is a general point.  Xiph policy
>> now encourages cover art in VorbisComments
>> using the METADATA_BLOCK_PICTURE tag,
>> visit:
>> http://wiki.xiph.org/VorbisComment#Cover_art
>>
>> This means that VorbisComments can be
>> huge, and so memory for them now needs to
>> be allocated from the heap, not the stack.
>
> Huge is relative.  Are people really sticking multi-megabyte binary
> comments at the head of Vorbis files?  Ugh.
>

Yes, I think this can easily happen where a tool or script is pulling  
down e.g., the best cover art match for given metadata. That's what  
happened to me. It would make sense for the tool to resize but not  
every tool will.

Adam


More information about the ogg-dev mailing list