[ogg-dev] Fixing ogg vorbis corruption caused by bad metadata

Monty Montgomery monty at xiph.org
Thu Jul 23 09:44:46 PDT 2009


> However, there is a general point.  Xiph policy
> now encourages cover art in VorbisComments
> using the METADATA_BLOCK_PICTURE tag,
> visit:
> http://wiki.xiph.org/VorbisComment#Cover_art
>
> This means that VorbisComments can be
> huge, and so memory for them now needs to
> be allocated from the heap, not the stack.

Huge is relative.  Are people really sticking multi-megabyte binary
comments at the head of Vorbis files?  Ugh.

The code should be updated if for no other reason that this doesn't
get blamed on us :-(

Monty


More information about the ogg-dev mailing list