[ogg-dev] oggz-validate does not seem to check for correctly framed headers

[Conrad Parker]

2008/11/11 Conrad Parker <conrad at metadecks.org>:
> 2008/11/11 Ivo Emanuel Gonçalves <justivo at gmail.com>:
>> While testing the new vcut, some of the early results had badly framed
>> headers.  I actually didn't notice it at first, because I was testing
>> with oggz-validate, but ogginfo does identify the problem:
>>
>> "WARNING: Vorbis stream X does not have headers correctly framed.
>> Terminal header page contains additional packets or has non-zero
>> granulepos"
>>
>> Conrad (or someone else) may want to change the tool to identify these
>> files.  There's a sample attached.
>
> Hi Ivo,
>
> good idea, and thanks for also supplying an example file!
>
> liboggz already knows how many headers each track should have, so it
> should be fairly straightforward to add a check for this that works
> for all codecs (assuming that the constraint -- that header and
> non-header packets must not share a page -- applies to all Ogg media
> types).

I've added the following checks in changeset:3778:

  Terminal header page has non-zero granulepos
  Terminal header page contains non-header packet
  Terminal header page contains non-header segment

It should work for all media types.

cheers,

Conrad.