[ogg-dev] Fwd: [PATCH] liboggz: Fix Dirac bitstream parsing

Ralph Giles giles at xiph.org
Tue Nov 4 15:10:48 PST 2008


On Tue, Nov 4, 2008 at 2:41 PM, David Flynn <davidf+nntp at woaf.net> wrote:

>> -    {50,1}, {60000,1001}, {60,1}, {15000,1001}, {25,2},
>> +    {50,1}, {60000,1001}, {60,1}, {15000,1001}, {25,2}
>
> Interesting -- i usually leave the final `,' there so that any future
> patch that appends something to the list doesn't have to modify the
> previous line to insert the ','

Good point about patches. I just though it was for editing
convenience. I've been broken of that by (ancient) compilers who are
confused by trailing commas. The file was inconsistent so I normalized
it in favour of my personal habit.

For liboggz I don't think it's important: people tend not to build
media software on such machines. So we can put them back if you want.

 -r


More information about the ogg-dev mailing list