[ogg-dev] [PATCH] browser_plugin - kate support, build fixes, and misc

[Conrad Parker]

2008/5/5 ogg.k.ogg.k at googlemail.com <ogg.k.ogg.k at googlemail.com>:
>> hmm, perhaps we should add some configure arguments like
>> --with-firefox-cflags= and --with-firefox-libs=
>
> I've made it a single one, --with-gecko-sdk= and also default
> include path and xpidl path to that if specified.

(applied after an email reminder, r3605)

> Also included are a patch that renames LIBOGGPLAY_* vars
> to OGGPLAY_* to match the latest change to configure.ac, and

the same fix was applied in r3600 and should have been attributed to
you as you'd sent this patch earlier, sorry

> one that allows the audio to be compiled out - that one's you
> may want to ignore, it just doesn't compile for me (ALSA 1.0.9)
> but I sent that just in case.

that could be useful if generalized; currently it just disables sound
for everyone ;-) Perhaps you could make it set a configure flag if
audio is explicitly disabled, or if no audio driver is detected, and
build an appropriate null audio device.

> Patches separated this time, sorry for not doing this earlier :)

Thanks, sorry for ignoring them anyway ;-)

Conrad.