[ogg-dev] [PATCH] skeleton.c

Conrad Parker conrad at metadecks.org
Sat Feb 2 17:19:50 PST 2008


On 03/02/2008, Ivo Emanuel Gonçalves <justivo at gmail.com> wrote:
> On 2/2/08, Conrad Parker <conrad at metadecks.org> wrote:
> > As far as I understand, that file is simply duplicated in each source
> > tree. It would be great if you could update it in each.
>
> I don't think it is that easy.  I have made a mere diff and see so
> many differences I'm not sure we can just blindly replace every
> skeleton.c with the one used in liboggz.
>
> Diff attached.

fair enough, thank you for checking.

I've looked through the diff, and it appears that the implementation
in the two libraries differs as follows:

 * oggenc's version uses oggenc's oe_write_page(), rather than
defining its own write_ogg_page_to_file()
 * oggenc's version does not implement the skeleton decode functions
fishead_from_ogg() and fisbone_from_ogg()

I edited the diff down to remove the parts which would change that.
It's committed in r14449, which also adds an endianness check to the
toplevel configure.ac.

cheers,

Conrad.


More information about the ogg-dev mailing list