[Icecast] ices2 metadata update causes gaps

[Paul Martin]

On Tue, Sep 27, 2005 at 11:42:00AM +0200, Michael Smith wrote:

> > I've just taken a "savefile" from ices2. The bumps aren't happening.
> > It's got to be in icecast2!
> 
> Wow, that sucks! This used to work perfectly, I guess someone broke
> it. That's a pretty nasty bug to have when we've just done a new
> release! I can see a 2.3.1 in the near future...

My money's on this code in format_vorbis.c, causing a duplicate packet 
at stream boundaries:

/* push last packet into stream marked with eos */
static void initiate_flush (vorbis_codec_t *source_vorbis)
{
    DEBUG0 ("adding EOS packet");
    if (source_vorbis->prev_packet)
    {
        /* insert prev_packet with eos */
        source_vorbis->prev_packet->e_o_s = 1;
        add_audio_packet (source_vorbis, source_vorbis->prev_packet);
        source_vorbis->prev_packet->e_o_s = 0;
    }
    source_vorbis->get_buffer_page = get_buffer_finished;
    source_vorbis->initial_audio_packet = 1;
}



-- 
Paul Martin <pm at zetnet.net> (work)
  <pm at nowster.zetnet.co.uk> (home)