[Icecast-dev] version 2.3.3, file log.c bug report

David Binderman dcb314 at hotmail.com
Fri Jun 28 02:22:40 PDT 2013

Hello there,

I just ran the static analysis checker "cppcheck" over the source code
of icecast version 2.3.3

Amongst many other things, it said

[log.c:301]: (warning) Logical conjunction always evaluates to false: log_id < 0 && log_id>= 25.

Source code is

    if (log_id < 0 && log_id>= LOG_MAXLOGS)

Suggest replace && with ||.


David Binderman 		 	   		  

More information about the Icecast-dev mailing list