[icecast-dev] No Duplicate Users - Patch

oddsock oddsock at oddsock.org
Sun May 16 20:31:51 PDT 2004

> >
> >       thread_rwlock_rlock(&state->file_rwlock);
> > +    if (!state->allow_duplicate_users) {
> > +        if (auth_is_listener_connected(source, username)) {
> > +            return AUTH_FAILED;
>Currently, we only have a generic 'AUTH_FAILED' here. I'd like to see an
>AUTH_FORBIDDEN (or some other name) added, which would be handled in the
>connection logic by returning a 403 (not a 401).
>What do you think of that?
reasonable...although very few media players actually accurately report 
HTTP error codes (Winamp does in the case of MP3 streaming only, not 
vorbis)..but that's no reason to not send the proper codes anyway...I'll 
add this to the patch...


<p>--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.

More information about the Icecast-dev mailing list