[icecast-dev] No Duplicate Users - Patch

[Michael Smith]

On Monday 17 May 2004 01:23, oddsock wrote:
> I'd like to commit the following patch which adds a new option to the
> htpasswd client authenticator.  This option <option
> name="allow_duplicate_users"> specifies wether or not the same username can
> connect to a mountpoint more than once.  This is pretty much a required
> feature for any decent use of the listener authentication capabilities of
> icecast.
>
> thoughts ? comments ?

This is good, but I have one comment...

>
>       thread_rwlock_rlock(&state->file_rwlock);
> +    if (!state->allow_duplicate_users) {
> +        if (auth_is_listener_connected(source, username)) {
> +            return AUTH_FAILED;

Currently, we only have a generic 'AUTH_FAILED' here. I'd like to see an 
AUTH_FORBIDDEN (or some other name) added, which would be handled in the 
connection logic by returning a 403 (not a 401).

What do you think of that?

Mike

--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.