[Icecast-dev] Re: [Icecast] [patch] time stamps in dump file names

[Karl Heyes]

<200406151403.05629.msmith at xiph.org>
Message-ID: <1087305291.2933.11.camel at bogus.hackers.club>

On Tue, 2004-06-15 at 05:03, Michael Smith wrote:
> On Monday 07 June 2004 07:43, Jochen Friedrich wrote:
> > Hi,
> >
> > this patch enables the use of time stamps in dump file names:
>
> Wouldn't it be better to make this conditional (on some other config file
> setting)? Not everyone wants this - but I suppose if they don't have % signs
> embedded in the filename it'll work as before.
>
> I'd accept (and commit) this with the following changes:
>  - Documentation! Absolute requirement.
>  - Check the return value from strftime(), and deal with that case
> appropriately.

also localtime is not thread safe. localtime_r really should be used.

karl.