[icecast-dev] BUG: sending bad buf's in MP3

[Ricardo Galli]

In format_mp3.c

tatic int format_mp3_write_buf_to_client(format_plugin_t *self,
    client_t *client, unsigned char *buf, int len)
{
    int ret;

    if(((mp3_state *)self->_state)->metadata)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This is always true because previously it did state->metadata = strdup("") 
in format_mp3_get_plugin().

It causes annoying artifacts in xmms while listening mp3, I suposse 
because xmms didn't ask for metadata.

Regards,


-- 
  ricardo galli       GPG id C8114D34

--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.