[icecast-dev] improved error.log output --diff

[John covici]

I just increased all the arguments to the macros by one and had to
put "-" where an ip address didn't have any meaning.  There are
better ways I could have done this, but this does work and gives the
correct information -- except for client added or removed where I cannot find an
ip addressof the client, but used the mount point instead -- which
turns out to be quite useful.

If you want to do this over in a more consistent way, feel free -- if
I do it it will take a while.

on  08/07/2003 Karl Heyes(karl at xiph.org) wrote
 > On Thu, 2003-08-07 at 13:51, John covici wrote:
 > 
 > While I agree that icecast logging needs improvement, I''m not so sure
 > about this patch.
 > 
 > > -        DEBUG1("Sending XSLT (%s)", fullpath_xslt_template);
 > > +        DEBUG1("Sending XSLT (%s), %s", fullpath_xslt_template, client->con->ip);
 > 
 > Can you explain why you want to change these macros, DEBUG1 would take 3
 > args with this. It would seem inconsistent.
 > 
 > 
 > > -                    WARN0("Had to close a listening socket");
 > > +                    WARN0("Had to close a listening socket, %s", "-");
 > 
 > whats the significance of "-", it's used in many areas ?
 > 
 > karl.
 > 
 > 
 > --- >8 ----
 > List archives:  http://www.xiph.org/archives/
 > icecast project homepage: http://www.icecast.org/
 > To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
 > containing only the word 'unsubscribe' in the body.  No subject is needed.
 > Unsubscribe messages sent to the list will be ignored/filtered.


-- 
         John Covici
         covici at ccs.covici.com
--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.