[icecast-dev] improved error.log output --diff

Karl Heyes karl at xiph.org
Thu Aug 7 06:40:01 PDT 2003



On Thu, 2003-08-07 at 13:51, John covici wrote:

While I agree that icecast logging needs improvement, I''m not so sure
about this patch.

> -        DEBUG1("Sending XSLT (%s)", fullpath_xslt_template);
> +        DEBUG1("Sending XSLT (%s), %s", fullpath_xslt_template, client->con->ip);

Can you explain why you want to change these macros, DEBUG1 would take 3
args with this. It would seem inconsistent.

<p>> -                    WARN0("Had to close a listening socket");
> +                    WARN0("Had to close a listening socket, %s", "-");

whats the significance of "-", it's used in many areas ?

karl.

<p>--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.



More information about the Icecast-dev mailing list