[icecast-dev] some portability fixes ...

[Li-Kai Liu]

Li-Kai Liu wrote:

> IV. conclusion
>
> i'm supposed to say something nice about icecast, but there are some 
> lousy programming in the source code despite the wide use of icecast 
> nowadays. if i have time i'd try to point them out.

orry i wasn't being very gentle, i must apologize, but in this sense i 
want everybody to know that i try to be honest. i think it is a very 
important thing -- to get something done, there is nothing wrong with 
taking things personally, but one should be able to bear critiques and 
etc. in order to improve.

just to sort of support myself, i'm going to point out that, when 
icecast opens a new dumping file in commands.c, it doesn't check if that 
stream already has a fd opened, and just overwrites 
sourcecon->food.source->dumpfd with the new fd without closing the old 
dumping one. in some systems it is impossible to delete the old dumping 
file without having that old fd closed.

it's a small oversight, but the outcome can be disasterous. say, if 
someone keeps dumping files but doesn't know to close them before 
dumping new ones, he would soon run out of fd's, and since socket also 
makes use of fd, his icecast would be unable to accept new connections. 
that not-so-smart system operator very effectively made a Denial of 
Service on himself without knowing it.

never meant to be mean,
regards,

liulk

--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to 'icecast-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.