[flac-dev] unsigned int and FLAC__uint32 are used interchangeably

Erik de Castro Lopo mle+la at mega-nerd.com
Sun Jan 15 01:23:24 UTC 2017


lvqcl wrote:

> Also MSVC fails because src/libFLAC/include/private/bitmath.h now
> contains "uint32_t long idx" instead of "unsigned long idx".

Ah, missed that because it was MSVC code. They should be `uint64_t`.

> According to MSDN _BitScanReverse*() functions have signatures:
> unsigned char _BitScanReverse(unsigned long *, unsigned long);
> unsigned char _BitScanReverse64(unsigned long *, unsigned __int64);

The `unsigned long` type should be synonymous with `uint64_t` so using
`uint64_t` should be safe. Furthermore if they aren't synonymous we
*want* that to be a compile error!

> Other than that, it compiles everything without errors.

Thanks!

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/


More information about the flac-dev mailing list