[flac-dev] unsigned int and FLAC__uint32 are used interchangeably

lvqcl lvqcl.mail at gmail.com
Sat Jan 14 22:14:13 UTC 2017


Ozkan Sezer wrote:

> Well, the commit seems like overkill :)  not all the unsigned needed
> converting.
>
> And build fails :
> format.c:53: error: conflicting types for 'FLAC__STREAM_SYNC'
> ../../include/FLAC/format.h:176: error: previous declaration of
> 'FLAC__STREAM_SYNC' was here
> [many others follow]


Also MSVC fails because src/libFLAC/include/private/bitmath.h now
contains "uint32_t long idx" instead of "unsigned long idx".

According to MSDN _BitScanReverse*() functions have signatures:
unsigned char _BitScanReverse(unsigned long *, unsigned long);
unsigned char _BitScanReverse64(unsigned long *, unsigned __int64);

Other than that, it compiles everything without errors.


More information about the flac-dev mailing list