[flac-dev] test_streams dependencies

[Brian Willoughby]

My assumption is that the code was written to call flac_fopen() so that it is portable to every operating system, even those without fopen(). If you replace flac_fopen() with fopen(), then the tests won't compile on systems that don't have fopen().

You could simply have the following:

#if defined _MSC_VER || defined __MINGW32__
#define flac_fopen fopen
#endif

In a header, or simply at the top of test_streams/main.c where there's already some conditional compilation.

Brian


On Jan 31, 2016, at 7:45 AM, lvqcl <lvqcl.mail at gmail.com> wrote:
> test_streams currently depends on grabbag and (on Windows) on win_utf8_io libs.
> It depends on win_utf8_io only because it uses flac_fopen() function.
> 
> It will become to depend on libFLAC when all file functions will be moved
> from win_utf8_io to libFLAC. Not a big problem, but it is possible to avoid
> this dependency by replacing flac_fopen() with fopen().
> 
> test_streams doesn't open/create files with unicode filenames, so it won't
> affect its functionality.
> 
> So, what's better:
> a) replace all flac_fopen() calls inside test_streams/main.c with fopen()
> b) leave it as is, so that on Windows build of test_streams will depend on libFLAC