[flac-dev] [PATCH] stream_encoder.c: choose proper *fixed_compute_best_predictor* function

Erik de Castro Lopo mle+la at mega-nerd.com
Mon Nov 23 11:15:44 PST 2015

lvqcl wrote:

> I found that 32-bit total_error_* variables in fixed_compute_best_predictor()
> functions can overflow. For example it happens with the attached test.wav and
> the following options: "-l 0 -b 4200 -m -r 5".
> The attached patch should fix it.
> (Now all three use_wide_by_* variables are unused, so I commented them out
> with #ifdef 0).

Rather than '#ifdef 0'-ing them out, shouldn't we remove them instead?

Erik de Castro Lopo

More information about the flac-dev mailing list