[flac-dev] [PATCH] stream_encoder.c: choose proper *fixed_compute_best_predictor* function

lvqcl lvqcl.mail at gmail.com
Mon Nov 23 10:29:48 PST 2015


I found that 32-bit total_error_* variables in fixed_compute_best_predictor()
functions can overflow. For example it happens with the attached test.wav and
the following options: "-l 0 -b 4200 -m -r 5".

The attached patch should fix it.

(Now all three use_wide_by_* variables are unused, so I commented them out
with #ifdef 0).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test.wav.zip
Type: application/zip
Size: 1214 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20151123/516d8a2b/attachment.zip 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixed_wide.patch
Type: application/octet-stream
Size: 3407 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20151123/516d8a2b/attachment.obj 


More information about the flac-dev mailing list