[flac-dev] Patch to improve malformed vorbiscomment handling

[Janne Hyvärinen]

Sorry for spamming but in the haste I forgot the stream_decoder part out.

On 26.9.2014 15:47, Janne Hyvärinen wrote:
> On 26.9.2014 15:21, Erik de Castro Lopo wrote:
>> Janne Hyvärinen wrote:
>>
>>> Patch v2, now handles more malformed cases. Original patch was for a
>>> file for which I had a sample from a user but this allows handling some
>>> manually broken test cases.
>>
>> Err, I'm getting warning messages on that patch:
>>
>>    CC       metadata_iterators.lo
>> metadata_iterators.c: In function 
>> ‘read_metadata_block_data_vorbis_comment_cb_’:
>> metadata_iterators.c:2238:12: error: comparison between 
>> ‘FLAC__Metadata_SimpleIteratorStatus’ and ‘enum <anonymous>’ 
>> [-Werror=enum-compare]
>>    if(status == FLAC__METADATA_CHAIN_STATUS_BAD_METADATA) goto skip;
>>              ^
>> metadata_iterators.c:2256:13: error: comparison between 
>> ‘FLAC__Metadata_SimpleIteratorStatus’ and ‘enum <anonymous>’ 
>> [-Werror=enum-compare]
>>     if(status == FLAC__METADATA_CHAIN_STATUS_BAD_METADATA) {
>>               ^
>>
>>
>>
>> Erik
>
> Darn, MSVC didn't warn anything and I didn't realize there are so many 
> BAD_METADATA statuses. I picked the first one autocomplete offered.
>
> One thing I don't like is that these don't return any warning messages 
> to tools. But I didn't see a way for the library to do that. I see 
> only fatal errors.
>
>
>
> _______________________________________________
> flac-dev mailing list
> flac-dev at xiph.org
> http://lists.xiph.org/mailman/listinfo/flac-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20140926/92f868f2/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: improve_malformed_comment_handling4.zip
Type: application/x-zip-compressed
Size: 2176 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20140926/92f868f2/attachment.bin