<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Sorry for spamming but in the haste I forgot the stream_decoder part
out.<br>
<br>
<div class="moz-cite-prefix">On 26.9.2014 15:47, Janne Hyvärinen
wrote:<br>
</div>
<blockquote cite="mid:54256064.9060003@sci.fi" type="cite">On
26.9.2014 15:21, Erik de Castro Lopo wrote:
<br>
<blockquote type="cite">Janne Hyvärinen wrote:
<br>
<br>
<blockquote type="cite">Patch v2, now handles more malformed
cases. Original patch was for a
<br>
file for which I had a sample from a user but this allows
handling some
<br>
manually broken test cases.
<br>
</blockquote>
<br>
Err, I'm getting warning messages on that patch:
<br>
<br>
CC metadata_iterators.lo
<br>
metadata_iterators.c: In function
‘read_metadata_block_data_vorbis_comment_cb_’:
<br>
metadata_iterators.c:2238:12: error: comparison between
‘FLAC__Metadata_SimpleIteratorStatus’ and ‘enum
<anonymous>’ [-Werror=enum-compare]
<br>
if(status == FLAC__METADATA_CHAIN_STATUS_BAD_METADATA) goto
skip;
<br>
^
<br>
metadata_iterators.c:2256:13: error: comparison between
‘FLAC__Metadata_SimpleIteratorStatus’ and ‘enum
<anonymous>’ [-Werror=enum-compare]
<br>
if(status == FLAC__METADATA_CHAIN_STATUS_BAD_METADATA) {
<br>
^
<br>
<br>
<br>
<br>
Erik
<br>
</blockquote>
<br>
Darn, MSVC didn't warn anything and I didn't realize there are so
many BAD_METADATA statuses. I picked the first one autocomplete
offered.
<br>
<br>
One thing I don't like is that these don't return any warning
messages to tools. But I didn't see a way for the library to do
that. I see only fatal errors.
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
flac-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a>
<a class="moz-txt-link-freetext" href="http://lists.xiph.org/mailman/listinfo/flac-dev">http://lists.xiph.org/mailman/listinfo/flac-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>