[flac-dev] PATCH for cpu.c

Oliver Stöneberg oliverst at online.de
Sun Mar 23 14:02:46 PDT 2014


> Oliver Stöneberg wrote:
> 
> > This is simply fixed by putting those unused constants into the
> > proper defines. I attached a patch against git 70b078c.
> 
> Unfortunately it breaks x86_64 build (where FLAC__CPU_X86_64 is defined, and
> FLAC__CPU_IA32 isn't). Maybe it's simpler to turn them into #defines such as
> 
>      #define FLAC__CPUINFO_IA32_CPUID_CMOV 0x00008000U
>      #define FLAC__CPUINFO_IA32_CPUID_EXTENDED_AMD_3DNOW 0x80000000U
> 
> and so on?

Maybe - I usually don't try to change the basics of code, but try to 
fix the errors properly.
I overlooked that code since it didn't exist in 1.2.1 and 1.3.0 and 
we never set the CPU defines before for MAME/MESS (will look into 
that).


More information about the flac-dev mailing list