[flac-dev] PATCH for cpu.c

lvqcl lvqcl.mail at gmail.com
Sat Mar 22 10:57:16 PDT 2014

Oliver Stöneberg wrote:

> This is simply fixed by putting those unused constants into the
> proper defines. I attached a patch against git 70b078c.

Unfortunately it breaks x86_64 build (where FLAC__CPU_X86_64 is defined, and
FLAC__CPU_IA32 isn't). Maybe it's simpler to turn them into #defines such as

     #define FLAC__CPUINFO_IA32_CPUID_CMOV 0x00008000U
     #define FLAC__CPUINFO_IA32_CPUID_EXTENDED_AMD_3DNOW 0x80000000U

and so on?

(Offtopic: FLAC doesn't use 3DNow if SSE is available, so 3DNow code is
useful only for K6-2, K6-III and Athlons up to Thunderbird. Maybe it's time to
begin to think about removal of 3DNow code?)

More information about the flac-dev mailing list