[flac-dev] Include directories

Erik de Castro Lopo mle+la at mega-nerd.com
Fri Jun 27 02:50:29 PDT 2014

Evan Ramos wrote:

> I tested my setup thoroughly and uncovered a remaining handful of
> issues, though I don't think they are directly related to your commit.
> (Though, removing plugin_xmms from the default build was helpful.)

We're keeping that plugin around because there are a small number of
people who do use it. It defnitely does not need to be built by default,
nor does it need to be built with the Makefile.lite build system.
> I took the liberty of removing "doc" from the dependencies of "all".

Yep , no need for that in the lite build system.

> The "src" and "plugin_common" targets required updates in a similar
> fashion to my previous patch. One broader change is that config.mk now
> relies on GNU Make's $(OS), in line with the separate components, and
> only invokes `uname -s` when it is undefined (which might never
> occur). Otherwise, every instance of $(OS) in the build system would
> have needed duplicate cases for "Windows" and "MINGW" because some
> make invocations include config.mk and others skip it.
> Along the way, I also fixed the following warning for x86_64-MinGW-w64
> builds, produced by every ".pic.o" object:
> >warning: -fPIC ignored for target (all code is position independent) [enabled by default]
> Patch attached.

Thanks. Applied and pushed.

Erik de Castro Lopo

More information about the flac-dev mailing list