[flac-dev] PATCH: Fix typo in conditional
Erik de Castro Lopo
mle+la at mega-nerd.com
Sun Feb 2 23:51:09 PST 2014
Robert Kausch wrote:
> Hi all,
>
> There's a typo in the conditional to check the exit condition in
> ascii_strcasecmp in share/utf8/charset.c. It checks for (!*s1 || !*s1)
> instead of (!*s1 || !*s2). Attached patch fixes this.
>
> Note that the typo did not affect the result of the function as the loop
> is exited before changing s1 or s2 anyway.
>
> The problem was found by cppcheck which is run automatically on the
> Debian sources. Results here:
> http://cppcheck.sourceforge.net/devinfo/daca2-cppcheck1.63/daca2.html
Great catch. Patch applied. Thanks.
Erik
--
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/
More information about the flac-dev
mailing list