[flac-dev] PATCH: Fix typo in conditional

Robert Kausch robert.kausch at freac.org
Sun Feb 2 07:24:48 PST 2014

Hi all,

There's a typo in the conditional to check the exit condition in 
ascii_strcasecmp in share/utf8/charset.c. It checks for (!*s1 || !*s1) 
instead of (!*s1 || !*s2). Attached patch fixes this.

Note that the typo did not affect the result of the function as the loop 
is exited before changing s1 or s2 anyway.

The problem was found by cppcheck which is run automatically on the 
Debian sources. Results here: 

Best regards,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flac-1.3.0-charset.patch
Type: text/x-patch
Size: 390 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20140202/112ba3be/attachment.bin 

More information about the flac-dev mailing list