[flac-dev] [PATCH] for flac/decode.c

[Erik de Castro Lopo]

lvqcl wrote:

> The commit http://git.xiph.org/?p=flac.git;a=commitdiff;h=99257e177eac96fa41a107b423080232f59ebe45
> also requires some changes in write_iff_headers() function:
> 
> currently flac don't write WAVEFORMATEXTENSIBLE header if
> decoder_session->channel_mask is equal to 0, 1 or 3.
> After the commit 99257e17 flac should do this for channel_mask
> equal to 0, 4 or 3.
> 
> The patch fixes this.

Applied, thanks.

> --------------------------
> Also, I have a question.
> 
> Currently flac complains about 24-bit .wav files if they have
> old WAVEFORMATEX header and not 'proper' WAVEFORMATEXTENSIBLE
> header. However it writes such files itself.
> 
> Is it better to fix this so it decodes 24-bit .flac files to .wav
> files with WAVEFORMATEXTENSIBLE header? Or is it better to leave
> things as is (for better compatibility with old programs)?

That's a good question. I have no idea how to answer that.

Maye what's needed is (another) command line flag.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/